[
https://issues.apache.org/jira/browse/HADOOP-6987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12917830#action_12917830
]
Konstantin Boudnik commented on HADOOP-6987:
--------------------------------------------
I don't like unnecessary inheritance in tests. This is, in fact, why I can't
stand JUnit3 ;)
The solution in the patch has one more disadvantage: what if we'll have tests
which shouldn't go over 10 secs, and others (i.e. true unit tests) which
shouldn't exceed 2 secs? Would offered solution force us to have different
implementations for different timeouts?
In this particular case I'd suggest to simply annotate test cases with expected
timeout as in
{noformat}
@Test(timeout=10000)
public void testEscapeString() throws Exception {
{noformat}
> Use JUnit Rule to optionally fail test cases that run more than 10 seconds
> --------------------------------------------------------------------------
>
> Key: HADOOP-6987
> URL: https://issues.apache.org/jira/browse/HADOOP-6987
> Project: Hadoop Common
> Issue Type: Improvement
> Components: test
> Affects Versions: 0.21.0
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Fix For: 0.22.0
>
> Attachments: HADOOP-6897.patch
>
>
> Using JUnit Rules annotations we can fail tests cases that take longer than
> 10 seconds (for instance) to run. This provides a regression check against
> test cases taking longer than they had previously due to unintended code
> changes, as well as provides a membership criteria for unit tests versus
> integration tests in HDFS and MR.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
