[
https://issues.apache.org/jira/browse/HADOOP-6987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12918951#action_12918951
]
Konstantin Boudnik commented on HADOOP-6987:
--------------------------------------------
I had an offline conversation with Jakob about this and he expressed that the
approach is about to enforce max time of a true unit test execution. Unit tests
are clearly suppose to be very short.
I still have a couple comments about this:
- let's call class {{UnitTestTimeLimit}} rather then
{{TenSecondsTimeoutPerTest}} to make it more generic
- let's make timeout to be a constant and move it to a config or util class
- let's update [Unit test
page|http://wiki.apache.org/hadoop/HowToDevelopUnitTests]
- as we are going to establish a precedent for setting rules of engagement I'd
suggest to update HADOOP-6399 with that rule
> Use JUnit Rule to optionally fail test cases that run more than 10 seconds
> --------------------------------------------------------------------------
>
> Key: HADOOP-6987
> URL: https://issues.apache.org/jira/browse/HADOOP-6987
> Project: Hadoop Common
> Issue Type: Improvement
> Components: test
> Affects Versions: 0.21.0
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Fix For: 0.22.0
>
> Attachments: HADOOP-6897.patch
>
>
> Using JUnit Rules annotations we can fail tests cases that take longer than
> 10 seconds (for instance) to run. This provides a regression check against
> test cases taking longer than they had previously due to unintended code
> changes, as well as provides a membership criteria for unit tests versus
> integration tests in HDFS and MR.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
