[
https://issues.apache.org/jira/browse/HADOOP-13105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15313164#comment-15313164
]
Chris Nauroth commented on HADOOP-13105:
----------------------------------------
The testing approach looks good to me. Here are a few comments on patch 002.
# I recommend adding a comment on {{AUTHENTICATE_SUCCESS_MSG}} to clarify what
is in that binary data.
# It's fun to see the lambdas. :-) This does mean it can't apply to branch-2
though. You'd either need to take away the lambdas for a patch that can apply
to both trunk and branch-2, or post separate patches.
> Support timeouts in LDAP queries in LdapGroupsMapping.
> ------------------------------------------------------
>
> Key: HADOOP-13105
> URL: https://issues.apache.org/jira/browse/HADOOP-13105
> Project: Hadoop Common
> Issue Type: Improvement
> Components: security
> Affects Versions: 3.0.0-alpha1
> Reporter: Chris Nauroth
> Assignee: Mingliang Liu
> Attachments: HADOOP-13105.000.patch, HADOOP-13105.001.patch,
> HADOOP-13105.002.patch
>
>
> {{LdapGroupsMapping}} currently does not set timeouts on the LDAP queries.
> This can create a risk of a very long/infinite wait on a connection.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
