[
https://issues.apache.org/jira/browse/HADOOP-13227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15314883#comment-15314883
]
Jing Zhao commented on HADOOP-13227:
------------------------------------
Thanks a lot for the great work, [~szetszwo]! The patch looks good to me. Some
minor comments:
# In RetryInfo#newRetryInfo, looks like failover, fail, and retry are mutual
exclusive? Then can we simplify RetryInfo and only keep one RetryAction there?
# In AsyncCallHandler, the queue will be accessed by many threads. Therefore
maybe we should consider directly using {{ConcurrentLinkedQueue}} which
utilizes an efficient non-block algorithm.
# In {{checkCalls}}, do you think we can avoid the poll+offer operations for a
not-done-yet call?
> AsyncCallHandler should use a event driven architecture to handle async calls
> -----------------------------------------------------------------------------
>
> Key: HADOOP-13227
> URL: https://issues.apache.org/jira/browse/HADOOP-13227
> Project: Hadoop Common
> Issue Type: Improvement
> Components: io, ipc
> Reporter: Tsz Wo Nicholas Sze
> Assignee: Tsz Wo Nicholas Sze
> Attachments: c13227_20160602.patch
>
>
> This JIRA is to address [Jing's
> comments|https://issues.apache.org/jira/browse/HADOOP-13226?focusedCommentId=15308630&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15308630]
> in HADOOP-13226.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
