[
https://issues.apache.org/jira/browse/HADOOP-13227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15319679#comment-15319679
]
Jing Zhao commented on HADOOP-13227:
------------------------------------
The latest patch looks good to me. The only minor comment:
{code}
final RetryAction a = failover != null? failover
: retry == null? fail: null;
{code}
Here {{a}} can be assigned with {{retry}} itself if {{retry}} is not
failover/null? Other than this +1.
> AsyncCallHandler should use a event driven architecture to handle async calls
> -----------------------------------------------------------------------------
>
> Key: HADOOP-13227
> URL: https://issues.apache.org/jira/browse/HADOOP-13227
> Project: Hadoop Common
> Issue Type: Improvement
> Components: io, ipc
> Reporter: Tsz Wo Nicholas Sze
> Assignee: Tsz Wo Nicholas Sze
> Attachments: c13227_20160602.patch, c13227_20160606.patch,
> c13227_20160607.patch
>
>
> This JIRA is to address [Jing's
> comments|https://issues.apache.org/jira/browse/HADOOP-13226?focusedCommentId=15308630&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15308630]
> in HADOOP-13226.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
