[
https://issues.apache.org/jira/browse/HADOOP-13061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15407110#comment-15407110
]
Kai Zheng commented on HADOOP-13061:
------------------------------------
Thanks Kai for the patch. It looks great. Some comments:
1. Ref. below:
{code}
+ public static ErasureEncoder createEncoder(ErasureCodec codec) {
+ return codec.createEncoder();
+ }
{code}
Could we have {{createEncoder(ErasureCodecOptions)}} instead?
ErasureCodecOptions could include all the necessary information from
configuration object that can be used to initialize a codec and encoder/decoder
thereafter.
2. So given above, the following could be changed to
{{AbstractErasureCodec(ErasureCodecOptions options)}}
{code}
+ public AbstractErasureCodec(ECSchema schema, ErasureCoderOptions options)
{code}
> Refactor erasure coders
> -----------------------
>
> Key: HADOOP-13061
> URL: https://issues.apache.org/jira/browse/HADOOP-13061
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Rui Li
> Assignee: Kai Sasaki
> Attachments: HADOOP-13061.01.patch, HADOOP-13061.02.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
