[ 
https://issues.apache.org/jira/browse/HADOOP-13061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15407703#comment-15407703
 ] 

Kai Sasaki commented on HADOOP-13061:
-------------------------------------

[~drankye] Thanks for reviewing. I have one thing to confirm.

{quote}
ErasureCodecOptions could include all the necessary information from 
configuration object that can be used to initialize a codec and encoder/decoder 
thereafter.
{quote}

Since codec information is already included in {{ECSchema}}, do you mean making 
{{ECSchema}} deprecated? Or do you intend to {{ECSchema}} is included in 
{{ErasureCodecOptions}}? 
I think the latter is better because {{ECSchema}} is already used by HDFS 
Erasure Coding.

My assumption is here.

1. {{ErasureCoderOptions}} can include {{ECSchema}}.
{code}
public final class ErasureCoderOptions {
  private final ECSchema schema;
  private final int numDataUnits;
  private final int numParityUnits;
  private final int numAllUnits;
  private final boolean allowChangeInputs;
  private final boolean allowVerboseDump;
}
{code}

2. {{CodecUtil}} creates corresponding {{ErasureCoder}} class with given codec 
which is included {{ECSchema}} in {{ErasureCoderOptions}}.

If {{ECSchema}} is not used anymore, {{ErasureCodecOptions}} needs to only 
include codec name.

> Refactor erasure coders
> -----------------------
>
>                 Key: HADOOP-13061
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13061
>             Project: Hadoop Common
>          Issue Type: Sub-task
>            Reporter: Rui Li
>            Assignee: Kai Sasaki
>         Attachments: HADOOP-13061.01.patch, HADOOP-13061.02.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to