[
https://issues.apache.org/jira/browse/HADOOP-13518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15427844#comment-15427844
]
Steve Loughran commented on HADOOP-13518:
-----------------------------------------
{code}
./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/FileSystemContractBaseTest.java:72:
/**: First sentence should end with a period.
./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/FileSystemContractBaseTest.java:556:
if (!renameSupported()) return;: 'if' construct must use '{}'s.
./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/FileSystemContractBaseTest.java:569:
if (!renameSupported()) return;: 'if' construct must use '{}'s.
./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/FileSystemContractBaseTest.java:589:
if (!renameSupported()) return;: 'if' construct must use '{}'s.
./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/FileSystemContractBaseTest.java:637:
if (!renameSupported()) return;: 'if' construct must use '{}'s.
./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/FileSystemContractBaseTest.java:651:
if (!renameSupported()) return;: 'if' construct must use '{}'s.
./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/FileSystemContractBaseTest.java:676:
fs.listFiles(dir, true);: 'fs' have incorrect indentation level 6,
expected level should be 8.
./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/FileSystemContractBaseTest.java:768:
int first_error_byte = -1;:9: Name 'first_error_byte' must match pattern
'^[a-z][a-zA-Z0-9]*$'.
./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3native/NativeS3FileSystem.java:759:
debugPreamble + "cannot rename a directory to a subdirectory of
self");: 'debugPreamble' have incorrect indentation level 12, expected level
should be 14.
./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3native/NativeS3FileSystem.java:759:
debugPreamble + "cannot rename a directory to a subdirectory of
self");: Line is longer than 80 characters (found 83).
{code}
> backport HADOOP-9258 to branch-2
> --------------------------------
>
> Key: HADOOP-13518
> URL: https://issues.apache.org/jira/browse/HADOOP-13518
> Project: Hadoop Common
> Issue Type: Task
> Components: fs, fs/s3, test
> Affects Versions: 2.9.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Attachments: HADOOP-13518-branch-2-001.patch
>
>
> I've just realised that HADOOP-9258 was never backported to branch 2. It went
> in to branch 1, and into trunk, but not in the bit in the middle.
> It adds
> -more fs contract tests
> -s3 and s3n rename don't let you rename under yourself (and delete)
> I'm going to try to create a patch for this, though it'll be tricky given how
> things have moved around a lot since then.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
