[
https://issues.apache.org/jira/browse/HADOOP-13591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15482183#comment-15482183
]
Steve Loughran commented on HADOOP-13591:
-----------------------------------------
# can we have a more explicit JIRA title; change logs like them
# I don't see any explicitly added tests. Has turning on root tests n the
contract options shown up this?
# ...and can you state which infrastructure you tested against. I'm confident
you did do the tests, just want to get all patches to this object store to
follow the same process as we have for the others: everyone declares what they
tested against, to keep us all honest
# {{AliyunOSSFileSystem}} line 160: use Use
{{org.apache.hadoop.fs.ParentNotDirectoryException}}
# general best practise is to use {{!String.isEmpty()}} over {{String.length()
>0}} as
the test for non-emptiness; makes it a bit clearer what is being looked for.
> issue about the logic of `directory` in Aliyun OSS
> --------------------------------------------------
>
> Key: HADOOP-13591
> URL: https://issues.apache.org/jira/browse/HADOOP-13591
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs
> Affects Versions: HADOOP-12756
> Reporter: Genmao Yu
> Assignee: Genmao Yu
> Fix For: HADOOP-12756
>
> Attachments: HADOOP-13591-HADOOP-12756.001.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
