[
https://issues.apache.org/jira/browse/HADOOP-13594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15487582#comment-15487582
]
Tsuyoshi Ozawa commented on HADOOP-13594:
-----------------------------------------
[~arpiagariu] filed HADOOP-13602 for addressing the warnings.
[~busbey] I'm assuming merging this after addressing all findbugs warnings.
{quote}
what does this buy us over the current flagging from precommit checks for
findbugs errors?
{quote}
Unfortunately, findbugs warnings gets overlooked sometimes(e.g. HADOOP-11602
calling String.toUpper/toLower without configuring locale). If the compile
fails when findbugs generate warnings, reviewers can notify them easily.
However, there is also cons: compile time will increase.
> findbugs warnings to block a build
> ----------------------------------
>
> Key: HADOOP-13594
> URL: https://issues.apache.org/jira/browse/HADOOP-13594
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Reporter: Tsuyoshi Ozawa
> Attachments: HADOOP-13594.001.patch
>
>
> findbugs is good tool, but we need to run separate command(mvn
> findbugs:check).
> Instead, it's better to run findbugs at compile time and block builds if it
> find errors.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
