[
https://issues.apache.org/jira/browse/HADOOP-13594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15487620#comment-15487620
]
Sean Busbey commented on HADOOP-13594:
--------------------------------------
{quote}
bq. what does this buy us over the current flagging from precommit checks for
findbugs errors?
Unfortunately, findbugs warnings gets overlooked sometimes(e.g. HADOOP-11602
calling String.toUpper/toLower without configuring locale). If the compile
fails when findbugs generate warnings, reviewers can notify them easily.
However, there is also cons: compile time will increase.
{quote}
I am extremely skeptical of fixing people-problems (like committers not
following the agreed criteria for commits and ignoring precommit feedback) with
heavy-handed tech choices. This effectively removes our ability to ignore a
false-positive and I suspect makes the on-boarding process for new contributors
unnecessarily hostile.
{quote}
Sean Busbey I'm assuming merging this after addressing all findbugs warnings.
{quote}
This won't help if the new contribution is what introduces a findbugs warning.
I would prefer we not hit new folks directly with the build failing without
there being sufficient guidance for them to fix things on their own. Could you
paste a sample output from a failed run? Maybe I'm overly concerned about the
impact this will have on the new contributor experience.
> findbugs warnings to block a build
> ----------------------------------
>
> Key: HADOOP-13594
> URL: https://issues.apache.org/jira/browse/HADOOP-13594
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Reporter: Tsuyoshi Ozawa
> Attachments: HADOOP-13594.001.patch
>
>
> findbugs is good tool, but we need to run separate command(mvn
> findbugs:check).
> Instead, it's better to run findbugs at compile time and block builds if it
> find errors.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
