[
https://issues.apache.org/jira/browse/HADOOP-13609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15500863#comment-15500863
]
Genmao Yu edited comment on HADOOP-13609 at 9/18/16 12:14 PM:
--------------------------------------------------------------
[~drankye]
updates:
1. typo fix: "static public" => "public static"
2. rename "getAccessKeys" => "getValueWithKey"
3. renam "TemporaryAliyunCredentialsProvider" =>
"AliyunSessionCredentialsProvider"
4. convert "import xxx.xxx.*" => seperate imports
5. keep "import static xxx.xxx.Constans.*" same style with others.
was (Author: unclegen):
[~drankye]
updates:
1. typo fix: "static public" => "public static"
2. rename "getAccessKeys" => "getValueWithKey"
3. renam "TemporaryAliyunCredentialsProvider" =>
"AliyunSessionCredentialsProvider"
4. convert "import xxx.xxx.*" => seperate imports
5. keep "import static xxx.xxx.Constans.*" with the same style with others.
> Refine credential provider related codes for AliyunOss integration
> ------------------------------------------------------------------
>
> Key: HADOOP-13609
> URL: https://issues.apache.org/jira/browse/HADOOP-13609
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs
> Affects Versions: HADOOP-12756
> Reporter: Kai Zheng
> Assignee: Genmao Yu
> Fix For: HADOOP-12756
>
> Attachments: HADOOP-13609-HADOOP-12756.001.patch,
> HADOOP-13609-HADOOP-12756.002.patch
>
>
> looking at the AliyunOss integration codes, some findings:
> 1. {{TemporaryAliyunCredentialsProvider}} could be better named;
> 2. TemporaryAliyunCredentialsProvider shared many codes with
> {{AliyunOSSUtils#getCredentialsProvider}}, and the dup can be resolved;
> 3. {{AliyunOSSUtils#getPassword}} is rather confusing, as used to get other
> things than password.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
