[ https://issues.apache.org/jira/browse/HADOOP-13609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15500894#comment-15500894 ]
Kai Zheng commented on HADOOP-13609: ------------------------------------ Thanks Genmao for the update! 2 comments: 1. Let's use AliyunCredentialsProvider for the name instead for brevity, no need to mention the session word. 2. Let's implement {{public void setCredentials(Credentials creds)}}. +1 once above addressed. > Refine credential provider related codes for AliyunOss integration > ------------------------------------------------------------------ > > Key: HADOOP-13609 > URL: https://issues.apache.org/jira/browse/HADOOP-13609 > Project: Hadoop Common > Issue Type: Sub-task > Components: fs > Affects Versions: HADOOP-12756 > Reporter: Kai Zheng > Assignee: Genmao Yu > Fix For: HADOOP-12756 > > Attachments: HADOOP-13609-HADOOP-12756.001.patch, > HADOOP-13609-HADOOP-12756.002.patch > > > looking at the AliyunOss integration codes, some findings: > 1. {{TemporaryAliyunCredentialsProvider}} could be better named; > 2. TemporaryAliyunCredentialsProvider shared many codes with > {{AliyunOSSUtils#getCredentialsProvider}}, and the dup can be resolved; > 3. {{AliyunOSSUtils#getPassword}} is rather confusing, as used to get other > things than password. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org