Andrew Wang commented on HADOOP-13721:

Good find Manoj. This is almost certainly supposed to be getTrashRoot and 

Related question though, does the default getTrashRoot implementation work for 
ViewFileSystem? It seems like we need to defer to the resolved filesystem's 
implementation, since DFS for instance re-implements it to support encryption 

> Remove stale method ViewFileSystem#getTrashCanLocation
> ------------------------------------------------------
>                 Key: HADOOP-13721
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13721
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 3.0.0-alpha2
>            Reporter: Manoj Govindassamy
>            Assignee: Manoj Govindassamy
>            Priority: Minor
>         Attachments: HADOOP-13721.01.patch
> {{ViewFileSystem}} which extends {{FileSystem}} has a public method 
> {{getTrashCanLocation}} which is neither overridden nor used by anybody. 
> Looks like it existed when the file was created, and also I see the 
> implementation returning homeDirectory which might not be the expected one in 
> cases of {{expunge}}. So, inclined to remove this stale and potentially 
> dangerous method unless anyone has any concerns. 
> {code}
>   public Path getTrashCanLocation(final Path f) throws FileNotFoundException {
>     final InodeTree.ResolveResult<FileSystem> res = 
>       fsState.resolve(getUriPath(f), true);
>     return res.isInternalDir() ? null : 
> res.targetFileSystem.getHomeDirectory();
>   }
> {code}

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to