[ 
https://issues.apache.org/jira/browse/HADOOP-13721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15576519#comment-15576519
 ] 

Hudson commented on HADOOP-13721:
---------------------------------

SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10616 (See 
[https://builds.apache.org/job/Hadoop-trunk-Commit/10616/])
HADOOP-13721. Remove stale method ViewFileSystem#getTrashCanLocation. (wang: 
rev aee538be6c2ab324de4d7834cd3347959272de01)
* (edit) 
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java


> Remove stale method ViewFileSystem#getTrashCanLocation
> ------------------------------------------------------
>
>                 Key: HADOOP-13721
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13721
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: viewfs
>    Affects Versions: 3.0.0-alpha2
>            Reporter: Manoj Govindassamy
>            Assignee: Manoj Govindassamy
>            Priority: Minor
>             Fix For: 3.0.0-alpha2
>
>         Attachments: HADOOP-13721.01.patch
>
>
> {{ViewFileSystem}} which extends {{FileSystem}} has a public method 
> {{getTrashCanLocation}} which is neither overridden nor used by anybody. 
> Looks like it existed when the file was created, and also I see the 
> implementation returning homeDirectory which might not be the expected one in 
> cases of {{expunge}}. So, inclined to remove this stale and potentially 
> dangerous method unless anyone has any concerns. 
> {code}
>   public Path getTrashCanLocation(final Path f) throws FileNotFoundException {
>     final InodeTree.ResolveResult<FileSystem> res = 
>       fsState.resolve(getUriPath(f), true);
>     return res.isInternalDir() ? null : 
> res.targetFileSystem.getHomeDirectory();
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to