[ 
https://issues.apache.org/jira/browse/HADOOP-11804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15623728#comment-15623728
 ] 

Andrew Wang commented on HADOOP-11804:
--------------------------------------

Thanks for working on this Sean!

Not sure why the patch didn't apply for precommit, since it applied for me 
locally. Since it modifies hadoop-maven-plugins, I "mvn install"'d it first per 
the normal build instructions.

Some review comments:

* Typos: "hte" "htey" "dependnecies" "itis"
* I see this comment: {{skip org.apache.avro:avro-ipc because it doesn't look 
like hadoop-common actually uses it}}. If there are other issues like this, 
it'd be nice to surface them in a JIRA comment or JIRA so we can think about 
fixing them properly.
* The build failed for me with this error:

{noformat}
[WARNING] Rule 1: org.apache.maven.plugins.enforcer.BanDuplicateClasses failed 
with message:
Duplicate classes found:

  Found in:
    org.apache.hadoop:hadoop-client-api:jar:3.0.0-alpha2-SNAPSHOT:compile
    
org.apache.hadoop:hadoop-client-minicluster:jar:3.0.0-alpha2-SNAPSHOT:compile
  Duplicate classes:
    
org/apache/hadoop/ipc/protobuf/TestRpcServiceProtos$TestProtobufRpc2Proto.class
    org/apache/hadoop/ipc/protobuf/TestProtos$EmptyResponseProto$Builder.class
    org/apache/hadoop/ipc/protobuf/TestProtos$1.class
    org/apache/hadoop/ipc/protobuf/TestProtos$SleepResponseProto$1.class
    
org/apache/hadoop/ipc/protobuf/TestRpcServiceProtos$OldProtobufRpcProto$Interface.class
    
org/apache/hadoop/ipc/protobuf/TestRpcServiceProtos$NewProtobufRpcProto$BlockingInterface.class
    org/apache/hadoop/ipc/protobuf/TestProtos$AuthMethodResponseProto$1.class
...<more proto classes>
{noformat}

trunk is a fast moving target, so if you give me your git hash, I can review 
against that.

> POC Hadoop Client w/o transitive dependencies
> ---------------------------------------------
>
>                 Key: HADOOP-11804
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11804
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: build
>            Reporter: Sean Busbey
>            Assignee: Sean Busbey
>         Attachments: HADOOP-11804.1.patch, HADOOP-11804.2.patch, 
> HADOOP-11804.3.patch, HADOOP-11804.4.patch
>
>
> make a hadoop-client-api and hadoop-client-runtime that i.e. HBase can use to 
> talk with a Hadoop cluster without seeing any of the implementation 
> dependencies.
> see proposal on parent for details.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to