[
https://issues.apache.org/jira/browse/HADOOP-11804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15625616#comment-15625616
]
Sean Busbey commented on HADOOP-11804:
--------------------------------------
Thanks for the review! I'll update to latest trunk as a part of getting the
rest of the feedback addressed.
I'm a bit concerned about the build failure, since even if you review against
my current commit (dbd2057), the hygiene check there (that the same class
doesn't end up in more than one of the shaded jars) would still have failed
later. I'm confused about test protobuf classes showing up in the client-api
jar, but hopefully the cause will be obvious once I rebase.
I'm planning to un-shade logging and htrace today, so if you'd prefer I not do
that please let me know. A related question, do we have a project-wide logging
framework?
{code}
Busbey-MBA:hadoop busbey$ git grep -l "org.slf4j" | grep "\\.java" | wc -l
320
Busbey-MBA:hadoop busbey$ git grep -l "org.apache.commons.logging" | grep
"\\.java" | wc -l
1410
Busbey-MBA:hadoop busbey$ git grep -l "java.util.logging" | grep "\\.java" |
wc -l
2
Busbey-MBA:hadoop busbey$ git grep -l "org.apache.log4j" | grep "\\.java" | wc
-l
217
Busbey-MBA:hadoop busbey$ git grep -l "org.apache.logging.log4j" | grep
"\\.java" | wc -l
0
{code}
Should I just un-shade all the logging libraries?
> POC Hadoop Client w/o transitive dependencies
> ---------------------------------------------
>
> Key: HADOOP-11804
> URL: https://issues.apache.org/jira/browse/HADOOP-11804
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: build
> Reporter: Sean Busbey
> Assignee: Sean Busbey
> Attachments: HADOOP-11804.1.patch, HADOOP-11804.2.patch,
> HADOOP-11804.3.patch, HADOOP-11804.4.patch
>
>
> make a hadoop-client-api and hadoop-client-runtime that i.e. HBase can use to
> talk with a Hadoop cluster without seeing any of the implementation
> dependencies.
> see proposal on parent for details.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
