[
https://issues.apache.org/jira/browse/HADOOP-13650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15637956#comment-15637956
]
Aaron Fabbri commented on HADOOP-13650:
---------------------------------------
Great progress [~eddyxu], just noticed you had a patch ready.
I haven't carefully reviewed the whole thing yet but here are some initial
comments:
Test code: Instead of changing the MetadataStoreTestBase to be
S3FileStatus-specific and removing the existing test code for FileStatus (which
I added in response to review comments), please create a subclass
TestDynamoDBMetadataStore and make the changes there. Let me know if you need
help with any refactoring. You should have a subclass of AbstractMSContract as
well. You can add an override-able query function to MetadataStoreTestBase
like {{boolean preservesFullFileStatus()}} which returns false for
TestDynamoDBMetadataStore, but true in the base class. In
MetadataStoreTestBase, if that function returns true, you can skip assertions
on those fields (accessTime, owner, group, etc.) instead of just removing the
base test code.
Code churn: FYI, I'm working on the upstream rebase but I hit some issues and
have to set up a new development machine. Trunk has a changed S3AFileStatus
constructor, so heads-up this will need to be rebased somewhat. I'll keep you
updated.
> S3Guard: Provide command line tools to manipulate metadata store.
> -----------------------------------------------------------------
>
> Key: HADOOP-13650
> URL: https://issues.apache.org/jira/browse/HADOOP-13650
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Reporter: Lei (Eddy) Xu
> Assignee: Lei (Eddy) Xu
> Attachments: HADOOP-13650-HADOOP-13345.000.patch,
> HADOOP-13650-HADOOP-13345.001.patch
>
>
> Similar systems like EMRFS has the CLI tools to manipulate the metadata
> store, i.e., create or delete metadata store, or {{import}}, {{sync}} the
> file metadata between metadata store and S3.
> http://docs.aws.amazon.com//ElasticMapReduce/latest/ReleaseGuide/emrfs-cli-reference.html
> S3Guard should offer similar functionality.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
