[ 
https://issues.apache.org/jira/browse/HADOOP-13650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lei (Eddy) Xu updated HADOOP-13650:
-----------------------------------
    Attachment: HADOOP-13650-HADOOP-13345.007.patch

Hi, [[email protected]]

Thanks for reviewing the patch.  I upload the patch to address your comments.

bq. S3GuardTool could just import Constants.*
done

bq. static private boolean exist(DynamoDB dynamoDB, String tableName) should be 
private static

Done.

bq. I think we should also have an fsck command which compares actual and 
declared, 

Could you help to clarify that what  the differences would be between {{s3a 
fsck}} and {{s3a diff}} in your mind?  For example, would {{diff + destroy + 
import}} equals to {{fsck fix up ddb}}, and adding a flag like {{s3a diff 
--fail-fast}} equals to {{fail with an exit code}}?

bq. that needs to be in this patch though, or a followon.

If the above differences are significant enough, I would like to file a follow 
on JIRA? What would you think?


Also, ping [~cnauroth], [~liuml07] and [~fabbri] for reviews.

Thanks!



> S3Guard: Provide command line tools to manipulate metadata store.
> -----------------------------------------------------------------
>
>                 Key: HADOOP-13650
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13650
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>    Affects Versions: HADOOP-13345
>            Reporter: Lei (Eddy) Xu
>            Assignee: Lei (Eddy) Xu
>         Attachments: HADOOP-13650-HADOOP-13345.000.patch, 
> HADOOP-13650-HADOOP-13345.001.patch, HADOOP-13650-HADOOP-13345.002.patch, 
> HADOOP-13650-HADOOP-13345.003.patch, HADOOP-13650-HADOOP-13345.004.patch, 
> HADOOP-13650-HADOOP-13345.005.patch, HADOOP-13650-HADOOP-13345.006.patch, 
> HADOOP-13650-HADOOP-13345.007.patch
>
>
> Similar systems like EMRFS has the CLI tools to manipulate the metadata 
> store, i.e., create or delete metadata store, or {{import}}, {{sync}} the 
> file metadata between metadata store and S3. 
> http://docs.aws.amazon.com//ElasticMapReduce/latest/ReleaseGuide/emrfs-cli-reference.html
> S3Guard should offer similar functionality. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to