[ 
https://issues.apache.org/jira/browse/HADOOP-13995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828448#comment-15828448
 ] 

Steve Loughran commented on HADOOP-13995:
-----------------------------------------

thanks. FWIW, I like messages even to assertions that are obvious in the 
source, as really, they should be obvious *in the jenkins test reports* without 
needing to go near the source.

I'd really like HADOOP-13589 to go in first, because its changing how we run 
the tests; I want newer tests (this, those in HADOOP-13985) to go in after 
that. Could everyone who can review/vote on HADOOP-13589, then I'll D/L and run 
this locally before voting on it.

regarding the endpoint declaration, it's being worked out in s3guard from the 
location of the bucket. Assuming these tests will only run if test.fs.s3a.name 
are set, then the endpoint can be automatically determined from the location of 
that bucket; we shouldn't need to redeclare it. This would also mean that if 
you switched to a v4 andpoint for the s3a bucket, the CLI tests switch with it. 

> s3guard cli: make tests easier to run and address failure
> ---------------------------------------------------------
>
>                 Key: HADOOP-13995
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13995
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>            Reporter: Aaron Fabbri
>            Assignee: Sean Mackrory
>         Attachments: HADOOP-13995.001.patch, HADOOP-13995.002.patch
>
>
> Following up on HADOOP-13650, we should:
> - Make it clearer which config parameters need to be set for test to succeed, 
> and provide good defaults.
> - Address any remaining test failures.
> - Change TestS3GuardTool to an ITest



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to