[ https://issues.apache.org/jira/browse/HADOOP-13995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828461#comment-15828461 ]
Sean Mackrory commented on HADOOP-13995: ---------------------------------------- {quote}ps: don't forget to have a diff with the right name for Yetus to do a review{quote} Ah - I hadn't noticed the feature-branch in the patch names. Will do - thanks. {quote}regarding the endpoint declaration, it's being worked out in s3guard from the location of the bucket. Assuming these tests will only run if test.fs.s3a.name are set, then the endpoint can be automatically determined from the location of that bucket; we shouldn't need to redeclare it. This would also mean that if you switched to a v4 andpoint for the s3a bucket, the CLI tests switch with it. {quote} Got it - I'll see if I can tweak the tests to not require a separately configured endpoint, then. > s3guard cli: make tests easier to run and address failure > --------------------------------------------------------- > > Key: HADOOP-13995 > URL: https://issues.apache.org/jira/browse/HADOOP-13995 > Project: Hadoop Common > Issue Type: Sub-task > Components: fs/s3 > Reporter: Aaron Fabbri > Assignee: Sean Mackrory > Attachments: HADOOP-13995.001.patch, HADOOP-13995.002.patch > > > Following up on HADOOP-13650, we should: > - Make it clearer which config parameters need to be set for test to succeed, > and provide good defaults. > - Address any remaining test failures. > - Change TestS3GuardTool to an ITest -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org