[ https://issues.apache.org/jira/browse/HADOOP-14038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15905319#comment-15905319 ]
John Zhuge commented on HADOOP-14038: ------------------------------------- Thanks [~vishwajeet.dusane] for the quick review. 1. Unfortunately I don't see any way to deprecate configuration properties who names contain dynamic portion. Are {{hostNameProperty}} and {{mountPointProperty}} being used by many customers? If yes, should we just keep the old names? 2. Maybe I miss something? TestValidateConfiguration does not seem to test deprecation at all. It only forces whoever changes AdlConfKeys to change this test class. For example: {code:title=AdlConfKeys} public static final String AZURE_AD_CLIENT_ID_KEY = "dfs.adls.oauth2.client.id"; {code} {code:title=TestValidateConfiguration} Assert.assertEquals("dfs.adls.oauth2.client.id", AZURE_AD_CLIENT_ID_KEY); {code} > Rename ADLS credential properties > --------------------------------- > > Key: HADOOP-14038 > URL: https://issues.apache.org/jira/browse/HADOOP-14038 > Project: Hadoop Common > Issue Type: Sub-task > Components: fs/adl > Affects Versions: 3.0.0-alpha3 > Reporter: John Zhuge > Assignee: John Zhuge > Priority: Minor > Attachments: HADOOP-14038.001.patch, HADOOP-14038.002.patch, > HADOOP-14038.003.patch, HADOOP-14038.004.patch, HADOOP-14038.005.patch > > > Add ADLS credential configuration properties to {{core-default.xml}}. > Set/document the default value for > {{dfs.adls.oauth2.access.token.provider.type}} to {{ClientCredential}}. > Fix {{AdlFileSystem#getAccessTokenProvider}} which implies the provider type > is {{Custom}}. > Fix several unit tests that set {{dfs.adls.oauth2.access.token.provider}} but > does not set {{dfs.adls.oauth2.access.token.provider.type}}. -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org