[
https://issues.apache.org/jira/browse/HADOOP-14038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15907157#comment-15907157
]
Steve Loughran commented on HADOOP-14038:
-----------------------------------------
LGTLM; some minor tweaks needed before it's ready to go in
Configuration#756
if the log.debug() message is doing string construction, the condition should
include a check for isDebug. Actually, as It may be useful to know that 0
configs were reloaded, consider just having the guard look at log level alone:
{code}
if (LOG.isDebugEnabled()) {
LOG.debug("Reloading " + cnt + " existing configurations");
}
{code}
{{TestAzureADTokenProvider}} should really be using GenericTestUtils to check
the message, or at least rethrow/wrap the inner stack trace.
{code}
if (!e.getMessage().contains(AZURE_AD_TOKEN_PROVIDER_CLASS_KEY))) throw e;
{code}
Stack traces are too valuable to lose, especially on a jenkins run.
> Rename ADLS credential properties
> ---------------------------------
>
> Key: HADOOP-14038
> URL: https://issues.apache.org/jira/browse/HADOOP-14038
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/adl
> Affects Versions: 3.0.0-alpha3
> Reporter: John Zhuge
> Assignee: John Zhuge
> Priority: Minor
> Attachments: HADOOP-14038.001.patch, HADOOP-14038.002.patch,
> HADOOP-14038.003.patch, HADOOP-14038.004.patch, HADOOP-14038.005.patch,
> HADOOP-14038.006.patch
>
>
> Add ADLS credential configuration properties to {{core-default.xml}}.
> Set/document the default value for
> {{dfs.adls.oauth2.access.token.provider.type}} to {{ClientCredential}}.
> Fix {{AdlFileSystem#getAccessTokenProvider}} which implies the provider type
> is {{Custom}}.
> Fix several unit tests that set {{dfs.adls.oauth2.access.token.provider}} but
> does not set {{dfs.adls.oauth2.access.token.provider.type}}.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
