[
https://issues.apache.org/jira/browse/HADOOP-14277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15956203#comment-15956203
]
Weiwei Yang commented on HADOOP-14277:
--------------------------------------
Hi [~ebadger]
Thanks for the notice. The intention of this test was to increase the testing
coverage for trash interface, to make sure it behaves correctly on a NN
restart. NN launches a new trash emptier thread when it gets started in
{{startActiveServices}}, so I used similar way in this test to verify
{{TrashPolicy#createCheckpoint}} and {{TrashPolicy#deleteCheckpoint}} can be
called as designed, and {{fs.trash.interval}} can be set correctly during a
restart.
Do you have the log of the jenkins job where this test failed? The test code
doesn't really do anything when deleting a checkpoint other than adding a count
in {{AuditableCheckpoints}}, so I am wondering why this could be flaky.
> TestTrash.testTrashRestarts is flaky
> ------------------------------------
>
> Key: HADOOP-14277
> URL: https://issues.apache.org/jira/browse/HADOOP-14277
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Eric Badger
>
> {noformat}
> junit.framework.AssertionFailedError: Expected num of checkpoints is 2, but
> actual is 3 expected:<2> but was:<3>
> at junit.framework.Assert.fail(Assert.java:57)
> at junit.framework.Assert.failNotEquals(Assert.java:329)
> at junit.framework.Assert.assertEquals(Assert.java:78)
> at junit.framework.Assert.assertEquals(Assert.java:234)
> at junit.framework.TestCase.assertEquals(TestCase.java:401)
> at
> org.apache.hadoop.fs.TestTrash.verifyAuditableTrashEmptier(TestTrash.java:892)
> at org.apache.hadoop.fs.TestTrash.testTrashRestarts(TestTrash.java:593)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
