[
https://issues.apache.org/jira/browse/HADOOP-14277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957029#comment-15957029
]
Eric Badger commented on HADOOP-14277:
--------------------------------------
bq. Does that make sense?
Yea, that makes a lot more sense. Thanks for the explanation. I think it would
be good to add a comment to the test or change the name of the test to make it
more clear about what it is testing.
bq. Maybe we should increase the trash interval from 50ms to 500ms, 50ms seems
to be too aggressive?
I think it would be better to mock/spy the {{AuditableTrashPolicy}} so that we
don't have to depend on a timeout at all. Instead, we can verify that the
relevant method has been called x number of times with a configured timeout of
something like 10 seconds.
bq. And were you seeing this failure in jenkins job results or while you are
doing some other stuff related to trash
This was just a nightly failure for our internal 2.8 build.
> TestTrash.testTrashRestarts is flaky
> ------------------------------------
>
> Key: HADOOP-14277
> URL: https://issues.apache.org/jira/browse/HADOOP-14277
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Eric Badger
>
> {noformat}
> junit.framework.AssertionFailedError: Expected num of checkpoints is 2, but
> actual is 3 expected:<2> but was:<3>
> at junit.framework.Assert.fail(Assert.java:57)
> at junit.framework.Assert.failNotEquals(Assert.java:329)
> at junit.framework.Assert.assertEquals(Assert.java:78)
> at junit.framework.Assert.assertEquals(Assert.java:234)
> at junit.framework.TestCase.assertEquals(TestCase.java:401)
> at
> org.apache.hadoop.fs.TestTrash.verifyAuditableTrashEmptier(TestTrash.java:892)
> at org.apache.hadoop.fs.TestTrash.testTrashRestarts(TestTrash.java:593)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
