[
https://issues.apache.org/jira/browse/HADOOP-14284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15962737#comment-15962737
]
Tsuyoshi Ozawa edited comment on HADOOP-14284 at 4/10/17 11:42 AM:
-------------------------------------------------------------------
Thanks Sean for your review.
{quote}
I presume we end up using our project wide LICENSE/NOTICE in this jar?
{quote}
{quote}
What are we trying to exclude here? I don't see much of consequence in the
guava jar.
{quote}
I think we shouldn't our L&N files here since we only use original Guava.
Hence, my intension is to remove our L&N files and to include L file which is
included in original Guava. Precisely, the L file is COPYING file in Guava's
repository. The change of excluding META-INF/**, however was my mistake - it
doesn't work. Thanks for pointing out. Instead of that, I added dummy
maven-remote-resources-plugin's process-resources section to remove our
original L&N files.
{quote}
Don't we need to have a dependency reduced pom in order to avoid having Guava
show up as a transitive dependency?
{quote}
I addressed to make the flag true in v4 patch.
was (Author: ozawa):
Thanks Seam for your review.
{quote}
I presume we end up using our project wide LICENSE/NOTICE in this jar?
{quote}
{quote}
What are we trying to exclude here? I don't see much of consequence in the
guava jar.
{quote}
I think we shouldn't our L&N files here since we only use original Guava.
Hence, my intension is to remove our L&N files and to include L file which is
included in original Guava. Precisely, the L file is COPYING file in Guava's
repository. The change of excluding META-INF/**, however was my mistake - it
doesn't work. Thanks for pointing out. Instead of that, I added dummy
maven-remote-resources-plugin's process-resources section to remove our
original L&N files.
{quote}
Don't we need to have a dependency reduced pom in order to avoid having Guava
show up as a transitive dependency?
{quote}
I addressed to make the flag true in v4 patch.
> Shade Guava everywhere
> ----------------------
>
> Key: HADOOP-14284
> URL: https://issues.apache.org/jira/browse/HADOOP-14284
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 3.0.0-alpha3
> Reporter: Andrew Wang
> Priority: Blocker
> Attachments: HADOOP-14238.pre001.patch, HADOOP-14284.002.patch,
> HADOOP-14284.004.patch
>
>
> HADOOP-10101 upgraded the guava version for 3.x to 21.
> Guava is broadly used by Java projects that consume our artifacts.
> Unfortunately, these projects also consume our private artifacts like
> {{hadoop-hdfs}}. They also are unlikely on the new shaded client introduced
> by HADOOP-11804, currently only available in 3.0.0-alpha2.
> We should shade Guava everywhere to proactively avoid breaking downstreams.
> This isn't a requirement for all dependency upgrades, but it's necessary for
> known-bad dependencies like Guava.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
