[
https://issues.apache.org/jira/browse/HADOOP-14284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15966061#comment-15966061
]
Tsuyoshi Ozawa edited comment on HADOOP-14284 at 4/13/17 4:22 PM:
------------------------------------------------------------------
Thanks Akira for trying the patch.
{quote}
The failure occurs because both the two module has shaded guava. Would you
remove shaded guava from hadoop-client-runtime module?
{quote}
Thanks for the suggestion. I could fix it by using shaded Guava in
hadoop-shaded-thirdparty, but I rechecked dependencies again before doing so.
After rechecking the dependency under hadoop-client-modules, I found that
hadoop-client-modules shouldn't use hadoop-shaded-thirdparty. It's because
hadoop-shaded-thirdparty exposes Guava's partial classes to use Apache Curator
but Apache Curator is only necessary in server side. In hadoop-client-modules,
we can shade Guava separately without using hadoop-shaded-thirdparty. I will
upload v10 patch with above approach.
was (Author: ozawa):
Thanks Akira for trying the patch.
{quote}
The failure occurs because both the two module has shaded guava. Would you
remove shaded guava from hadoop-client-runtime module?
{quote}
Thanks for the suggestion. I could fix it by using shaded Guava in
hadoop-shaded-thirdparty, but I checked dependencies again. After rechecking
the dependency under hadoop-client-modules, I found that hadoop-client-modules
shouldn't use hadoop-shaded-thirdparty. It's because hadoop-shaded-thirdparty
exposes Guava's partial classes to use Apache Curator but Apache Curator is
only necessary in server side. In hadoop-client-modules, we can shade Guava
separately without using hadoop-shaded-thirdparty. I will upload v10 patch
which includes above approach.
> Shade Guava everywhere
> ----------------------
>
> Key: HADOOP-14284
> URL: https://issues.apache.org/jira/browse/HADOOP-14284
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 3.0.0-alpha3
> Reporter: Andrew Wang
> Assignee: Tsuyoshi Ozawa
> Priority: Blocker
> Attachments: HADOOP-14238.pre001.patch, HADOOP-14284.002.patch,
> HADOOP-14284.004.patch, HADOOP-14284.007.patch, HADOOP-14284.010.patch
>
>
> HADOOP-10101 upgraded the guava version for 3.x to 21.
> Guava is broadly used by Java projects that consume our artifacts.
> Unfortunately, these projects also consume our private artifacts like
> {{hadoop-hdfs}}. They also are unlikely on the new shaded client introduced
> by HADOOP-11804, currently only available in 3.0.0-alpha2.
> We should shade Guava everywhere to proactively avoid breaking downstreams.
> This isn't a requirement for all dependency upgrades, but it's necessary for
> known-bad dependencies like Guava.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
