[
https://issues.apache.org/jira/browse/HADOOP-14248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15963537#comment-15963537
]
Chris Nauroth commented on HADOOP-14248:
----------------------------------------
Hello [~liuml07]. This looks good overall. I have a comment on the branch-2
patch.
{code}
private SharedInstanceProfileCredentialsProvider() {
- super();
+ InstanceProfileCredentialsProvider.getInstance();
}
{code}
I don't think this change is necessary. The call to
{{InstanceProfileCredentialsProvider#getInstance()}} returns an instance
(always the same one now that we've upgraded the AWS SDK), but then it never
saves a reference to that instance or does anything else with it.
> Retire SharedInstanceProfileCredentialsProvider in trunk; deprecate in
> branch-2
> -------------------------------------------------------------------------------
>
> Key: HADOOP-14248
> URL: https://issues.apache.org/jira/browse/HADOOP-14248
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Affects Versions: 3.0.0-alpha3
> Reporter: Mingliang Liu
> Assignee: Mingliang Liu
> Attachments: HADOOP-14248.000.patch, HADOOP-14248.001.patch,
> HADOOP-14248-branch-2.001.patch
>
>
> This is from the discussion in [HADOOP-13050].
> So [HADOOP-13727] added the SharedInstanceProfileCredentialsProvider, which
> effectively reduces high number of connections to EC2 Instance Metadata
> Service caused by InstanceProfileCredentialsProvider. That patch, in order to
> prevent the throttling problem, defined new class
> {{SharedInstanceProfileCredentialsProvider}} as a subclass of
> {{InstanceProfileCredentialsProvider}}, which enforces creation of only a
> single instance.
> Per [HADOOP-13050], we upgraded the AWS Java SDK. Since then, the
> {{InstanceProfileCredentialsProvider}} in SDK code internally enforces a
> singleton. That confirms that our effort in [HADOOP-13727] makes 100% sense.
> Meanwhile, {{SharedInstanceProfileCredentialsProvider}} can retire gracefully
> in trunk branch.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
