[
https://issues.apache.org/jira/browse/HADOOP-14248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15964937#comment-15964937
]
Chris Nauroth commented on HADOOP-14248:
----------------------------------------
[~liuml07], this looks good now, and I confirmed a full test run against
US-west-2.
However, I'm now thinking that we need two separates JIRA issues, just for the
sake of accurate tracking against target versions and release notes.
HADOOP-14248 would track the removal from trunk (already covered by the current
release note), and the new issue would be targeted to 2.9.0 with a different
release note describing deprecation instead of removal. (No need to repeat
pre-commit. I'd just comment on the new JIRA that pre-commit for branch-2 was
already covered here.)
Do you think that makes sense? If so, I'd be happy to be the JIRA janitor and
finish off committing this. :-)
> Retire SharedInstanceProfileCredentialsProvider in trunk; deprecate in
> branch-2
> -------------------------------------------------------------------------------
>
> Key: HADOOP-14248
> URL: https://issues.apache.org/jira/browse/HADOOP-14248
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Affects Versions: 3.0.0-alpha3
> Reporter: Mingliang Liu
> Assignee: Mingliang Liu
> Attachments: HADOOP-14248.000.patch, HADOOP-14248.001.patch,
> HADOOP-14248-branch-2.001.patch, HADOOP-14248-branch-2.002.patch
>
>
> This is from the discussion in [HADOOP-13050].
> So [HADOOP-13727] added the SharedInstanceProfileCredentialsProvider, which
> effectively reduces high number of connections to EC2 Instance Metadata
> Service caused by InstanceProfileCredentialsProvider. That patch, in order to
> prevent the throttling problem, defined new class
> {{SharedInstanceProfileCredentialsProvider}} as a subclass of
> {{InstanceProfileCredentialsProvider}}, which enforces creation of only a
> single instance.
> Per [HADOOP-13050], we upgraded the AWS Java SDK. Since then, the
> {{InstanceProfileCredentialsProvider}} in SDK code internally enforces a
> singleton. That confirms that our effort in [HADOOP-13727] makes 100% sense.
> Meanwhile, {{SharedInstanceProfileCredentialsProvider}} can retire gracefully
> in trunk branch.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
