[
https://issues.apache.org/jira/browse/HADOOP-13200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15975922#comment-15975922
]
Kai Zheng commented on HADOOP-13200:
------------------------------------
Thanks [~timmyyao] for working thru this and updating the patches. LGTM and my
+1.
I'm happy we can get rid of static things like follows,
{code}
- // Default coders for each codec names.
- public static final Map<String, String> DEFAULT_CODERS_MAP = ImmutableMap.of(
- "rs", IO_ERASURECODE_CODEC_RS_RAWCODERS_DEFAULT,
- "rs-legacy", IO_ERASURECODE_CODEC_RS_LEGACY_RAWCODERS_DEFAULT,
- "xor", IO_ERASURECODE_CODEC_XOR_RAWCODERS_DEFAULT
- );
{code}
by registries like the following, in In
hadoop-common-project/hadoop-common/src/main/resources/META-INF/services/org.apache.hadoop.io.erasurecode.rawcoder.RawErasureCoderFactory:
{code}
+org.apache.hadoop.io.erasurecode.rawcoder.NativeRSRawErasureCoderFactory
+org.apache.hadoop.io.erasurecode.rawcoder.NativeXORRawErasureCoderFactory
+org.apache.hadoop.io.erasurecode.rawcoder.RSRawErasureCoderFactory
+org.apache.hadoop.io.erasurecode.rawcoder.RSRawErasureCoderFactoryLegacy
+org.apache.hadoop.io.erasurecode.rawcoder.XORRawErasureCoderFactory
{code}
[~andrew.wang], [~jojochuang] maybe you also want to take a look? If no other
comments in a couple of days, I will commit it.
> Seeking a better approach allowing to customize and configure erasure coders
> ----------------------------------------------------------------------------
>
> Key: HADOOP-13200
> URL: https://issues.apache.org/jira/browse/HADOOP-13200
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Kai Zheng
> Assignee: Tim Yao
> Priority: Blocker
> Labels: hdfs-ec-3.0-must-do
> Attachments: HADOOP-13200.02.patch, HADOOP-13200.03.patch,
> HADOOP-13200.04.patch, HADOOP-13200.05.patch
>
>
> This is a follow-on task for HADOOP-13010 as discussed over there. There may
> be some better approach allowing to customize and configure erasure coders
> than the current having raw coder factory, as [~cmccabe] suggested. Will copy
> the relevant comments here to continue the discussion.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
