[
https://issues.apache.org/jira/browse/HADOOP-13200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15977041#comment-15977041
]
Wei-Chiu Chuang commented on HADOOP-13200:
------------------------------------------
Hello [~drankye]
Thanks for inviting me for comments, and thank [~timmyyao] for the multiple
round of revisions.
I made a quick pass of the patch, and I'd like to share a few comments, mostly
on supportability and scalability:
* what's the visibility of the new class CodecRegistry? I think it just needs
package private, or at most Hadoop-only visibility (i.e.
{{\@InterfaceAudience.Private}})
* In the CodecRegistry constructor, please add debug level (or trace) log to
print the codec put into the registry.
* In the CodecRegistry constructor, could you make sure there is no existing
coders in the list with the same coder name?
* I am not familiar with Java 8 Lambda functions, but if I understand it
correctly, {{CodecRegistry#getCoderNames}} returns a new String list every time
it is called. Because this method is called whenever a DFSStripedOutputStream
object is instantiated, it could cause extra heap usage over the long run.
> Seeking a better approach allowing to customize and configure erasure coders
> ----------------------------------------------------------------------------
>
> Key: HADOOP-13200
> URL: https://issues.apache.org/jira/browse/HADOOP-13200
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Kai Zheng
> Assignee: Tim Yao
> Priority: Blocker
> Labels: hdfs-ec-3.0-must-do
> Attachments: HADOOP-13200.02.patch, HADOOP-13200.03.patch,
> HADOOP-13200.04.patch, HADOOP-13200.05.patch
>
>
> This is a follow-on task for HADOOP-13010 as discussed over there. There may
> be some better approach allowing to customize and configure erasure coders
> than the current having raw coder factory, as [~cmccabe] suggested. Will copy
> the relevant comments here to continue the discussion.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
