[ 
https://issues.apache.org/jira/browse/HADOOP-14338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15980713#comment-15980713
 ] 

Weiwei Yang commented on HADOOP-14338:
--------------------------------------

Hi [~Naganarasimha]

Good point. I just looked at the code a bit, however,  I did not find a default 
{{YarnConfiguration. NM_LINUX_CONTAINER_CGROUPS_MOUNT_PATH}}. Looks like it is 
reasonable to set a default value such as

{code}
NM_LINUX_CONTAINER_CGROUPS_MOUNT_PATH_DEFAULT=/sys/fs/cgroup
{code}

hmm ... but there seems more work. If we set a default value to 
{{/sys/fs/cgroups}} and use that as default. If user sets 
{{yarn.nodemanager.linux-container-executor.cgroups.mount}} without explicitly 
setting  {{yarn.nodemanager.linux-container-executor.cgroups.mount-path}}, it 
will mount cgroups to {{/sys/fs/cgroups}} no matter what under neath linux 
distribution is, would that cause problems? Looks like we need a check here. 
What do you think?

> Fix warnings from Spotbugs in hadoop-yarn
> -----------------------------------------
>
>                 Key: HADOOP-14338
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14338
>             Project: Hadoop Common
>          Issue Type: Sub-task
>            Reporter: Weiwei Yang
>            Assignee: Weiwei Yang
>         Attachments: HADOOP-14338.001.patch, HADOOP-14338.002.patch, 
> HADOOP-14338.003.patch, HADOOP-14338.004.patch, HADOOP-14338.005.patch
>
>
> Fix warnings from Spotbugs in hadoop-yarn since switched from findbugs to 
> spotbugs.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to