[
https://issues.apache.org/jira/browse/HADOOP-13200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982136#comment-15982136
]
Wei-Chiu Chuang commented on HADOOP-13200:
------------------------------------------
Hi [~timmyyao]
Thanks a lot for the new rev. It looks almost good, and I am +1 after just
three nits:
* Please add a {{\@VisibleForTesting}} annotation to the method {{updateCoders}}
* Please remove this comment
{code}
//userDefinedFactories.add(new RSUserDefinedFactory());
{code}
* Since we switched to slf4j, could we also use curl style parameters? Note
that without using parameterized logging, this would incur additional parameter
construction cost, which is not a good idea for debug messages. E.g.
{code}
LOG.debug("Codec registered: codec = {}, coder = {}",
coderFactory.getCodecName(),coderFactory.getCoderName());
{code}
The user doc is not that obvious to first time users. But let's defer that to a
new jira.
Would any one else like to comment? Now's a good time :)
> Seeking a better approach allowing to customize and configure erasure coders
> ----------------------------------------------------------------------------
>
> Key: HADOOP-13200
> URL: https://issues.apache.org/jira/browse/HADOOP-13200
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Kai Zheng
> Assignee: Tim Yao
> Priority: Blocker
> Labels: hdfs-ec-3.0-must-do
> Attachments: HADOOP-13200.02.patch, HADOOP-13200.03.patch,
> HADOOP-13200.04.patch, HADOOP-13200.05.patch, HADOOP-13200.06.patch,
> HADOOP-13200.07.patch, HADOOP-13200.08.patch
>
>
> This is a follow-on task for HADOOP-13010 as discussed over there. There may
> be some better approach allowing to customize and configure erasure coders
> than the current having raw coder factory, as [~cmccabe] suggested. Will copy
> the relevant comments here to continue the discussion.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
