[ 
https://issues.apache.org/jira/browse/HADOOP-11614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982645#comment-15982645
 ] 

Masatake Iwasaki commented on HADOOP-11614:
-------------------------------------------

Thanks for the update, [~ajisakaa]. The patch looks good. Just 1 nit.

There is no relevant logger in new httpcore/httpclient. I think we can just 
remove the line.
{noformat}
 #crank back on warnings about -1 content length GETs
-log4j.logger.org.apache.commons.httpclient.HttpMethodBase=ERROR
+log4j.logger.org.apache.http.client.methods.HttpGet=ERROR
{noformat}

I ran unit tests including contract tests against Rackspace Cloud Files. Only 
{{TestSwiftContractRootDir#testRmNonEmptyRootDirNonRecursive}} failed but it 
seems not to be related to the fix since it failed even without the patch.

{noformat}
Running org.apache.hadoop.fs.swift.contract.TestSwiftContractRootDir
Tests run: 9, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 103.302 sec <<< 
FAILURE! - in org.apache.hadoop.fs.swift.contract.TestSwiftContractRootDir
testRmNonEmptyRootDirNonRecursive(org.apache.hadoop.fs.swift.contract.TestSwiftContractRootDir)
  Time elapsed: 13.245 sec  <<< FAILURE!
java.lang.AssertionError: File claims to be a directory 
/testRmNonEmptyRootDirNonRecursive  SwiftFileStatus{ 
path=swift://testfs.rackspace/testRmNonEmptyRootDirNonRecursive; 
isDirectory=true; length=0; blocksize=33554432; modification_time=1493112657000}
        at org.junit.Assert.fail(Assert.java:88)
        at org.junit.Assert.assertTrue(Assert.java:41)
        at org.junit.Assert.assertFalse(Assert.java:64)
        at 
org.apache.hadoop.fs.contract.ContractTestUtils.assertIsFile(ContractTestUtils.java:726)
        at 
org.apache.hadoop.fs.contract.ContractTestUtils.assertIsFile(ContractTestUtils.java:715)
        at 
org.apache.hadoop.fs.contract.AbstractFSContractTestBase.assertIsFile(AbstractFSContractTestBase.java:316)
        at 
org.apache.hadoop.fs.contract.AbstractContractRootDirectoryTest.testRmNonEmptyRootDirNonRecursive(AbstractContractRootDirectoryTest.java:138)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:497)
        at 
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
        at 
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
        at 
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
        at 
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
        at 
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
        at 
org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
        at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
        at 
org.junit.internal.runners.statements.FailOnTimeout$StatementThread.run(FailOnTimeout.java:74)
{noformat}


> Remove httpclient dependency from hadoop-openstack
> --------------------------------------------------
>
>                 Key: HADOOP-11614
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11614
>             Project: Hadoop Common
>          Issue Type: Sub-task
>            Reporter: Akira Ajisaka
>            Assignee: Brahma Reddy Battula
>            Priority: Blocker
>         Attachments: HADOOP-11614-002.patch, HADOOP-11614-003.patch, 
> HADOOP-11614-004.patch, HADOOP-11614-005.patch, HADOOP-11614-006.patch, 
> HADOOP-11614-007.patch, HADOOP-11614.patch
>
>
> Remove httpclient dependency from hadoop-openstack and its pom.xml file.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to