[
https://issues.apache.org/jira/browse/HADOOP-14284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15996980#comment-15996980
]
stack commented on HADOOP-14284:
--------------------------------
bq. However, I found one problem in this approach: shaded artifacts(shaded
Guava and Curator) in hadoop-shaded-thirdparty is NOT in classpath, if I
understand correctly.
Tell us more please. Shading bundles the relocated .class files of guava and
curator; they are included in the thirdparty jar... and the thirdparty jar is
on the classpath, no?
Perhaps you are referring to the downsides listed in the comment 'stack added a
comment - 06/Apr/17 00:57' over in HADOOP-13363 where IDEs will not be able to
find the shaded imports? For this reason hbase-protocol-shaded includes
relocated src (it does a build because we patch protobuf3).
> Shade Guava everywhere
> ----------------------
>
> Key: HADOOP-14284
> URL: https://issues.apache.org/jira/browse/HADOOP-14284
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 3.0.0-alpha3
> Reporter: Andrew Wang
> Assignee: Tsuyoshi Ozawa
> Priority: Blocker
> Attachments: HADOOP-14238.pre001.patch, HADOOP-14284.002.patch,
> HADOOP-14284.004.patch, HADOOP-14284.007.patch, HADOOP-14284.010.patch
>
>
> HADOOP-10101 upgraded the guava version for 3.x to 21.
> Guava is broadly used by Java projects that consume our artifacts.
> Unfortunately, these projects also consume our private artifacts like
> {{hadoop-hdfs}}. They also are unlikely on the new shaded client introduced
> by HADOOP-11804, currently only available in 3.0.0-alpha2.
> We should shade Guava everywhere to proactively avoid breaking downstreams.
> This isn't a requirement for all dependency upgrades, but it's necessary for
> known-bad dependencies like Guava.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
