[ https://issues.apache.org/jira/browse/HADOOP-14284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15999486#comment-15999486 ]
Tsuyoshi Ozawa commented on HADOOP-14284: ----------------------------------------- [~djp] It's another option. IMHO, it sounds more tough work than we expected - e.g. HDFS core including DataNode.java uses CacheBuilder. Could you share the examples that can be caused even with shading? The patch looks large, but it's just a change of importing and pom.xml. [~busbey] thanks a lot! Your advice is correct. I used jarjar-maven-plugin to be before the package phase([I'm using process-classes to pass tests for now|https://github.com/oza/hadoop/blob/HADOOP-14284/hadoop-shaded-thirdparty/pom.xml#L84]) because shade:shade is bound to the package phase. The v12 patch includes the change. PR for review on github is available [here|https://github.com/apache/hadoop/pull/210]. > Shade Guava everywhere > ---------------------- > > Key: HADOOP-14284 > URL: https://issues.apache.org/jira/browse/HADOOP-14284 > Project: Hadoop Common > Issue Type: Bug > Components: build > Affects Versions: 3.0.0-alpha3 > Reporter: Andrew Wang > Assignee: Tsuyoshi Ozawa > Priority: Blocker > Attachments: HADOOP-14238.pre001.patch, HADOOP-14284.002.patch, > HADOOP-14284.004.patch, HADOOP-14284.007.patch, HADOOP-14284.010.patch, > HADOOP-14284.012.patch > > > HADOOP-10101 upgraded the guava version for 3.x to 21. > Guava is broadly used by Java projects that consume our artifacts. > Unfortunately, these projects also consume our private artifacts like > {{hadoop-hdfs}}. They also are unlikely on the new shaded client introduced > by HADOOP-11804, currently only available in 3.0.0-alpha2. > We should shade Guava everywhere to proactively avoid breaking downstreams. > This isn't a requirement for all dependency upgrades, but it's necessary for > known-bad dependencies like Guava. -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org