[ 
https://issues.apache.org/jira/browse/HADOOP-14518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16051884#comment-16051884
 ] 

Steve Loughran commented on HADOOP-14518:
-----------------------------------------

looks pretty good, just needs some final tuning

* typo "configuraion" in docs. 
* checkstyle has found 3 minor issues, which we need to get in
{code}
./hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/AzureNativeFileSystemStore.java:57:import
 org.apache.hadoop.fs.azure.SyncableDataOutputStream;:1: Redundant import from 
the same package - org.apache.hadoop.fs.azure.SyncableDataOutputStream. 
[RedundantImport]
./hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/AzureNativeFileSystemStore.java:58:import
 org.apache.hadoop.fs.azure.SelfThrottlingIntercept;:1: Redundant import from 
the same package - org.apache.hadoop.fs.azure.SelfThrottlingIntercept. 
[RedundantImport]
./hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/AzureNativeFileSystemStore.java:1927:
        
connection.setRequestProperty(Constants.HeaderConstants.USER_AGENT,userAgentInfo);:76:
 ',' is not followed by whitespace. [WhitespaceAfter]
{code}

> Customize User-Agent header sent in HTTP/HTTPS requests by WASB.
> ----------------------------------------------------------------
>
>                 Key: HADOOP-14518
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14518
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: fs/azure
>    Affects Versions: 3.0.0-alpha3
>            Reporter: Georgi Chalakov
>            Assignee: Georgi Chalakov
>            Priority: Minor
>         Attachments: HADOOP-14518-01.patch, HADOOP-14518-01-test.txt, 
> HADOOP-14518-02.patch, HADOOP-14518-03.patch
>
>
> WASB passes a User-Agent header to the Azure back-end. Right now, it uses the 
> default value set by the Azure Client SDK, so Hadoop traffic doesn't appear 
> any different from general Blob traffic. If we customize the User-Agent 
> header, then it will enable better troubleshooting and analysis by Azure 
> service.
> The following configuration
>   <property>
>     <name>fs.azure.user.agent.id</name>
>     <value>MSFT</value>
>   </property>
> set the user agent to 
>      User-Agent: WASB/3.0.0-alpha4-SNAPSHOT (MSFT) Azure-Storage/4.2.0 
> (JavaJRE 1.8.0_131; WindowsServer2012R2 6.3)
> Test Results :
> Tests run: 703, Failures: 0, Errors: 0, Skipped: 119



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to