[
https://issues.apache.org/jira/browse/HADOOP-14518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16055516#comment-16055516
]
Steve Loughran commented on HADOOP-14518:
-----------------------------------------
Test failures appear unrelated; I'll have to see if I can replicate them & work
out what changed. I can't see how it has broken from your patch, certainly.
Regarding this patch, the production code looks OK.
# I'd like to see a test which sets the property to something other than the
default, just to make sure that codepath doesn't have surprises. You can just
add it to some existing test suite, like {{TestWasbUriAndConfiguration}} or
similar: just set the property one time an agent is created. Maybe also unset
it entirely to see what happens.
* I'll require a declaration from you as to which azure endpoint you tested
against. I'm confident you have the ability to do this, I just want the
rigorousness. Yetus/Jenkins can't test the azure client (no credentials), so we
absolutely require that due diligence from the submitter. (we committers
generally do a test run too, but I don't want to invest the time until its
ready to play with)
> Customize User-Agent header sent in HTTP/HTTPS requests by WASB.
> ----------------------------------------------------------------
>
> Key: HADOOP-14518
> URL: https://issues.apache.org/jira/browse/HADOOP-14518
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs/azure
> Affects Versions: 3.0.0-alpha3
> Reporter: Georgi Chalakov
> Assignee: Georgi Chalakov
> Priority: Minor
> Attachments: HADOOP-14518-01.patch, HADOOP-14518-01-test.txt,
> HADOOP-14518-02.patch, HADOOP-14518-03.patch, HADOOP-14518-04.patch
>
>
> WASB passes a User-Agent header to the Azure back-end. Right now, it uses the
> default value set by the Azure Client SDK, so Hadoop traffic doesn't appear
> any different from general Blob traffic. If we customize the User-Agent
> header, then it will enable better troubleshooting and analysis by Azure
> service.
> The following configuration
> <property>
> <name>fs.azure.user.agent.id</name>
> <value>MSFT</value>
> </property>
> set the user agent to
> User-Agent: WASB/3.0.0-alpha4-SNAPSHOT (MSFT) Azure-Storage/4.2.0
> (JavaJRE 1.8.0_131; WindowsServer2012R2 6.3)
> Test Results :
> Tests run: 703, Failures: 0, Errors: 0, Skipped: 119
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
