[
https://issues.apache.org/jira/browse/HADOOP-14553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16075714#comment-16075714
]
Aaron Fabbri commented on HADOOP-14553:
---------------------------------------
Thank you for doing this work [[email protected]]. I'm running the tests in
US West now.
Overall this patch contains a lot of goodness. Besides the ITest refactoring I
see a lot of improved test cleanup and some reduced code duplication. I wonder
if some of the common code pasted from S3A could be factored out (huge files
and test utils classes). That said, this is an improvement overall so I'd be
fine with some lower-priority JIRAs to follow up on factoring out the common
hugefiles and testutils stuff.
{noformat}
+ <configuration>
+ <forkCount>1</forkCount>
+<!-- <forkCount>${testsThreadCount}</forkCount>-->
+ <reuseForks>false</reuseForks>
+ <argLine>${maven-surefire-plugin.argLine}
-DminiClusterDedicatedDirs=true</argLine>
{noformat}
Is this a temporary workaround for a unit-test parallelization issue?
{noformat}
+public class ITestNativeAzureFileSystemContractLive extends
<snip>
- @Before
+ @Before
public void setUp() throws Exception {
{noformat}
Formatting nit at Before annotation.
{noformat}
-public class TestNativeAzureFileSystemContractMocked extends
+/**
+ * Mocked testing of FileSystemContractBaseTest.
+ * This isn't an IT, but making it so makes it a lot faster for now.
+ */
+public class ITestNativeAzureFileSystemContractMocked extends
{noformat}
Just curious, why is it faster as ITest?
> Add (parallelized) integration tests to hadoop-azure
> ----------------------------------------------------
>
> Key: HADOOP-14553
> URL: https://issues.apache.org/jira/browse/HADOOP-14553
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/azure
> Affects Versions: 2.9.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Attachments: HADOOP-14553-001.patch, HADOOP-14553-002.patch,
> HADOOP-14553-003.patch, HADOOP-14553-004.patch
>
>
> The Azure tests are slow to run as they are serialized, as they are all
> called Test* there's no clear differentiation from unit tests which Jenkins
> can run, and integration tests which it can't.
> Move the azure tests {{Test*}} to integration tests {{ITest*}}, parallelize
> (which includes having separate paths for every test suite). The code in
> hadoop-aws's POM &c show what to do.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
