[
https://issues.apache.org/jira/browse/HADOOP-14637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16081172#comment-16081172
]
Jason Lowe commented on HADOOP-14637:
-------------------------------------
The check after looping is always needed, even for the case where wait time is
a multiple of the check interval. We should not assume the check call is
instantaneous nor that we wakeup exactly when requested. So sounds like
there's two things to fix here, the missing check after the wait expires and
fixing the TestRMRestart case to call with correct arguments. I'm hesitant to
remove the precondition check, and it caught a bug here. Is there a real need
to allow wait < check in practice?
> After HADOOP-14568, TestRMRestart.testRMRestartWaitForPreviousAMToFinish()
> fails with IllegalArgumentException
> --------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-14637
> URL: https://issues.apache.org/jira/browse/HADOOP-14637
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 3.0.0-alpha4
> Reporter: Daniel Templeton
> Assignee: Daniel Templeton
> Labels: newbie
> Attachments: HADOOP-14637.001.patch, HADOOP-14637.002.patch
>
>
> {noformat}
> org.apache.hadoop.yarn.server.resourcemanager.TestRMRestart
> testRMRestartWaitForPreviousAMToFinish(org.apache.hadoop.yarn.server.resourcemanager.TestRMRestart)
> Time elapsed: 23.718 sec <<< ERROR!
> java.lang.IllegalArgumentException: Total wait time should be greater than
> check interval time
> at
> com.google.common.base.Preconditions.checkArgument(Preconditions.java:88)
> at
> org.apache.hadoop.test.GenericTestUtils.waitFor(GenericTestUtils.java:341)
> at
> org.apache.hadoop.yarn.server.resourcemanager.TestRMRestart.testRMRestartWaitForPreviousAMToFinish(TestRMRestart.java:618)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
