[
https://issues.apache.org/jira/browse/HADOOP-14637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16083041#comment-16083041
]
Jason Lowe commented on HADOOP-14637:
-------------------------------------
Thanks for updating the patch! I'm also torn on whether to keep the arg check
or not, but I lean towards keeping it simply for the fact that it caught this
bug and would have caught a bug in HDFS-11711 which prompted the change in
HADOOP-14568. I believe the net effect is it helps more than it hurts, but
like you I don't feel very strongly about it.
While looking over the latest patch I noticed another small bug that would be
nice to fix since we're here. GenericTestUtils.waitFor should be calling
Time.monotonicNow rather than Time.now so in case the system clock adjusts
during unit testing we don't get an incorrect timeout period. It's not
technically related to this change, so if you think it should be addressed in
another JIRA I'm good with that too.
> After HADOOP-14568, TestRMRestart.testRMRestartWaitForPreviousAMToFinish()
> fails with IllegalArgumentException
> --------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-14637
> URL: https://issues.apache.org/jira/browse/HADOOP-14637
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 3.0.0-alpha4
> Reporter: Daniel Templeton
> Assignee: Daniel Templeton
> Labels: newbie
> Attachments: HADOOP-14637.001.patch, HADOOP-14637.002.patch,
> HADOOP-14637.003.patch, HADOOP-14637.004.patch
>
>
> {noformat}
> org.apache.hadoop.yarn.server.resourcemanager.TestRMRestart
> testRMRestartWaitForPreviousAMToFinish(org.apache.hadoop.yarn.server.resourcemanager.TestRMRestart)
> Time elapsed: 23.718 sec <<< ERROR!
> java.lang.IllegalArgumentException: Total wait time should be greater than
> check interval time
> at
> com.google.common.base.Preconditions.checkArgument(Preconditions.java:88)
> at
> org.apache.hadoop.test.GenericTestUtils.waitFor(GenericTestUtils.java:341)
> at
> org.apache.hadoop.yarn.server.resourcemanager.TestRMRestart.testRMRestartWaitForPreviousAMToFinish(TestRMRestart.java:618)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
