[ https://issues.apache.org/jira/browse/HADOOP-14672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16093874#comment-16093874 ]
Sean Busbey commented on HADOOP-14672: -------------------------------------- let's just fold this under HADOOP-14089. They have the same basic prerequisite: we need to automate checking for non-relocated classes in all of the shaded artifacts. {quote} I also see some mapreduce, hdfs, common classes are unshaded. At the same time, some other classes are shaded. I assume we should make them all shaded. {quote} The terminology around making bundled artifacts is often confusing. Here, do you mean "included in a jar that is built from the contents of other jars" or do you mean "relocated to be in a java package under org.apache.hadoop"? The various client jars should contain contents from other jars, but just those needed for the given jar's particular purpose. In the case of the hadoop-client-minicluster artifact that should be the classes needed to run an instance of the various miniclusters for testing purposes, but none of the things included in hadoop-client-api or hadoop-client-runtime. Any classes included ought to be in a package under org.apache.hadoop (I think the default is to put them in {{org.apache.hadoop.shaded._original_package_}}. > Shaded Hadoop-client-minicluster include unshaded classes, like: javax, sax, > dom, etc. > -------------------------------------------------------------------------------------- > > Key: HADOOP-14672 > URL: https://issues.apache.org/jira/browse/HADOOP-14672 > Project: Hadoop Common > Issue Type: Sub-task > Reporter: Junping Du > Assignee: Bharat Viswanadham > Priority: Blocker > > The shaded hadoop-client-minicluster shouldn't include any unshaded > dependencies, but we can see: javax, dom, sax, etc. are all unshaded. > CC [~busbey] -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org