[
https://issues.apache.org/jira/browse/HADOOP-14672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16100165#comment-16100165
]
Sean Busbey commented on HADOOP-14672:
--------------------------------------
{quote}
Yes, they are used in the tests internally. I don't know whether these will be
used by downstream projects or not. So, do i need to update the patch to
exclude them?
{quote}
In that case, I would exclude them entirely. easier to add them back later if
there's a specific test use case for downstream than it is to maintain keeping
them for no reason.
{quote}
org/w3c/dom/HTMLDOMImplementation is from xerces:xercesImpl jar.
Updated the code to shade the class(HTMLDOMImplementation) from that jar.
{quote}
Is something specifically using Xerces? I've been trying to remove Xerces from
downstream facing dependencies off-and-on for a long time. I think it
originally got added so that some fsimage tool would work in the IBM JVM. If
nothing is specifically using it, I think we should exclude this as well.
> Shaded Hadoop-client-minicluster include unshaded classes, like: javax, sax,
> dom, etc.
> --------------------------------------------------------------------------------------
>
> Key: HADOOP-14672
> URL: https://issues.apache.org/jira/browse/HADOOP-14672
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Junping Du
> Assignee: Bharat Viswanadham
> Priority: Blocker
> Attachments: HADOOP-14672.02.patch, HADOOP-14672.03.patch,
> HADOOP-14672.04.patch, HADOOP-14672.patch
>
>
> The shaded hadoop-client-minicluster shouldn't include any unshaded
> dependencies, but we can see: javax, dom, sax, etc. are all unshaded.
> CC [~busbey]
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
