[
https://issues.apache.org/jira/browse/HADOOP-14672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16100538#comment-16100538
]
Junping Du commented on HADOOP-14672:
-------------------------------------
bq. I thought we were in agreement that they shouldn't be in the shaded jar.
Why would we publish them to downstream? They're used in a test we run
internally, we don't intend for them to be used downstream, right?
Ideally, it is true that these test jars are not marked as public or
LimitedPrivate so shouldn't be used by downstream projects. However, it would
be great if we can check those main stream projects, such as HBase, Hive, etc.
won't use them at all. Otherwise, some related tests for downstream projects
could get break. I like the idea to separate it into a dedicated JIRA for
additional discussion and verification. [~busbey], what do you think?
Xerces sounds like a complicated issue across different JVMs. Can we just leave
it there or treat it as normal third party classes? Any side-effect if we shade
Xerces classes as third party classes?
> Shaded Hadoop-client-minicluster include unshaded classes, like: javax, sax,
> dom, etc.
> --------------------------------------------------------------------------------------
>
> Key: HADOOP-14672
> URL: https://issues.apache.org/jira/browse/HADOOP-14672
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Junping Du
> Assignee: Bharat Viswanadham
> Priority: Blocker
> Attachments: HADOOP-14672.02.patch, HADOOP-14672.03.patch,
> HADOOP-14672.04.patch, HADOOP-14672.patch
>
>
> The shaded hadoop-client-minicluster shouldn't include any unshaded
> dependencies, but we can see: javax, dom, sax, etc. are all unshaded.
> CC [~busbey]
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
