[ 
https://issues.apache.org/jira/browse/HADOOP-14768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16176798#comment-16176798
 ] 

Thomas Marquardt commented on HADOOP-14768:
-------------------------------------------

I opened HADOOP-14768.005.patch and still see major changes to 
{{NativeAzureFileSystem.delete}}.  

The point of my earlier feedback is that we should minimize risk for medium to 
high risk changes that are going to be ported to branch-2.  We can do this by 
using config to enable the new functionality without a significant impact to 
existing functionality.

What I had in mind is that you would leave the current delete code as-is and 
add a new delete method for the case when authorization is enabled:

{code:java}

public boolean delete(...) throws IOException {
  if (azureAuthorization) {
    return deleteWithAuthEnabled(...);
  }
  // current delete code goes here
}

private boolean deleteWithAuthEnabled(...) throws IOException {
  // new delete code for the case when authorization is enabled goes here
}
{code}




> Honoring sticky bit during Deletion when authorization is enabled in WASB
> -------------------------------------------------------------------------
>
>                 Key: HADOOP-14768
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14768
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/azure
>            Reporter: Varada Hemeswari
>            Assignee: Varada Hemeswari
>              Labels: fs, secure, wasb
>         Attachments: HADOOP-14768.001.patch, HADOOP-14768.002.patch, 
> HADOOP-14768.003.patch, HADOOP-14768.003.patch, HADOOP-14768.004.patch, 
> HADOOP-14768.004.patch, HADOOP-14768.005.patch
>
>
> When authorization is enabled in WASB filesystem, there is a need for 
> stickybit in cases where multiple users can create files under a shared 
> directory. This additional check for sticky bit is reqired since any user can 
> delete another user's file because the parent has WRITE permission for all 
> users.
> The purpose of this jira is to implement sticky bit equivalent for 'delete' 
> call when authorization is enabled.
> Note : Sticky bit implementation for 'Rename' operation is not done as part 
> of this JIRA



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to