[
https://issues.apache.org/jira/browse/HADOOP-14768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16184226#comment-16184226
]
Varada Hemeswari commented on HADOOP-14768:
-------------------------------------------
Thanks [[email protected]] for the review.
I have addressed most of you comments in [^HADOOP-14768.007.patch]. Except the
following two
1. I did not change the exceptions thrown to PathIsNotEmptyDirectoryException
or org.apache.hadoop.fs.PathIsNotDirectoryException(in both the paths)
2. L2484: use Collection.addAll() to add list - I am not sure of the value add
here. Leaving as it is hoping its not a blocker for commit.
{quote}L2088. Issue: if a recursive delete failed, should that update the last
modified time of the parent dir? Or is it as the actual dir being modified is
itself not deleted, you don't have to. If that's true, given the dir being
deleted is still there, does its modtime need to be changed?{quote}
- Following the convention of auth disabled flow, if the delete is partial,
that is delete fails to completely clean up all files(not just the dir on which
delete is requested), we skip modifying the parent's last updated time of any
file/folder though some of them have successfully deleted..
I have run the hadoop-azure tests again in auth enabled and disabled flows
against azure storage account in South India.
> Honoring sticky bit during Deletion when authorization is enabled in WASB
> -------------------------------------------------------------------------
>
> Key: HADOOP-14768
> URL: https://issues.apache.org/jira/browse/HADOOP-14768
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/azure
> Reporter: Varada Hemeswari
> Assignee: Varada Hemeswari
> Labels: fs, secure, wasb
> Attachments: HADOOP-14768.001.patch, HADOOP-14768.002.patch,
> HADOOP-14768.003.patch, HADOOP-14768.003.patch, HADOOP-14768.004.patch,
> HADOOP-14768.004.patch, HADOOP-14768.005.patch, HADOOP-14768.006.patch,
> HADOOP-14768.007.patch
>
>
> When authorization is enabled in WASB filesystem, there is a need for
> stickybit in cases where multiple users can create files under a shared
> directory. This additional check for sticky bit is reqired since any user can
> delete another user's file because the parent has WRITE permission for all
> users.
> The purpose of this jira is to implement sticky bit equivalent for 'delete'
> call when authorization is enabled.
> Note : Sticky bit implementation for 'Rename' operation is not done as part
> of this JIRA
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
