[ 
https://issues.apache.org/jira/browse/HADOOP-14944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16204489#comment-16204489
 ] 

John Zhuge commented on HADOOP-14944:
-------------------------------------

KMSWebApp changes
* Don’t think the Servlet context is the right place to create the JVM-global 
{{JvmMetrics}} and {{JvmPauseMonitor}}. Suggest moving the code to the end of 
{{KMSWebServer#KMSWebServer}}.
* {{JvmMetrics#initSingleton}} is a bit simpler than JvmMetrics#create.
* Move PROCESS_NAME to KMSConfiguration. Or even hardcoded string “KMS” is fine.

testKMSJMX
* Consider JMX URL 
{{/jmx?user.name=dr.who&qry=Hadoop:service=KMS,name=JvmMetrics}} to limit the 
output.

> Add JvmMetrics to KMS
> ---------------------
>
>                 Key: HADOOP-14944
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14944
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: kms
>    Affects Versions: 2.6.0
>            Reporter: Xiao Chen
>            Assignee: Xiao Chen
>         Attachments: HADOOP-14944.01.patch
>
>
> Let's make KMS to use {{JvmMetrics}} to report aggregated statistics about 
> heap / GC etc.
> This will make statistics monitoring easier, and compatible across the 
> tomcat-based (branch-2) KMS and the jetty-based (branch-3) KMS.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to