[
https://issues.apache.org/jira/browse/HADOOP-14944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16207000#comment-16207000
]
Xiao Chen commented on HADOOP-14944:
------------------------------------
Thanks John for taking the effort and presenting a patch directly! Agree this
now feels mostly developing the JvmMetrics class than kms - still in the mighty
hadoop code base. :)
I like your idea to provide a less hacky solution. Implementation-wise, though,
{{shutdown}} is not really shutting down now. I made some improvement in patch
6 to bring more parity in shutdown to init, and enriched javadoc to explain.
For the same reason javadoc explained, I think we're good now to not changing
all other places where {{initSingleton}} is invoked to also shutdown. Hoping
this javadoc would be helpful for people to add {{JvmMetrics}} to other classes
in the future.
Unrelated, I found {{JvmMetrics}}' constructor not being a private is not
helping. Added a {{VisibleForTesting}} annotation to it.
Also, {{TestJvmMetrics}} is testing more pause monitor than jvm metrics, but
I'd like to leave this out from this jira to keep our focus.
> Add JvmMetrics to KMS
> ---------------------
>
> Key: HADOOP-14944
> URL: https://issues.apache.org/jira/browse/HADOOP-14944
> Project: Hadoop Common
> Issue Type: Improvement
> Components: kms
> Affects Versions: 2.6.0
> Reporter: Xiao Chen
> Assignee: Xiao Chen
> Attachments: HADOOP-14944.01.patch, HADOOP-14944.02.patch,
> HADOOP-14944.03.patch, HADOOP-14944.04.patch, HADOOP-14944.05.patch,
> HADOOP-14944.branch-2.01.patch
>
>
> Let's make KMS to use {{JvmMetrics}} to report aggregated statistics about
> heap / GC etc.
> This will make statistics monitoring easier, and compatible across the
> tomcat-based (branch-2) KMS and the jetty-based (branch-3) KMS.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
