[ 
https://issues.apache.org/jira/browse/HADOOP-15003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16241246#comment-16241246
 ] 

Aaron Fabbri commented on HADOOP-15003:
---------------------------------------

Ok I reviewed all the newest changes on the [pull 
request|https://github.com/apache/hadoop/pull/282]
(as of writing, most recent commit is df094d7).

I applied the patch to trunk and ran all the S3A integration tests in 
us-west-2.  I had some failures in the "huge" magic committer test:

{noformat}
  
ITestHugeMagicCommits.test_030_postCreationAssertions:112->AbstractFSContractTestBase.assertPathExists:294
 » FileNotFound
  
ITestHugeMagicCommits>AbstractSTestS3AHugeFiles.test_040_PositionedReadHugeFile:351->AbstractSTestS3AHugeFiles.assumeHugeFileExists:310->AbstractSTestS3AHugeFiles.assumeFileExists:320
 » FileNotFound
{noformat}

which went away when I ran tests in serial mode.  Minus that, and considering 
that the staging committer is the initial focus, this feels like it is ready 
for a merge.  Do you want to put this on a feature branch (short term only 
please) or commit to trunk?

> Merge S3A committers into trunk: Yetus patch checker
> ----------------------------------------------------
>
>                 Key: HADOOP-15003
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15003
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>    Affects Versions: 3.0.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>         Attachments: HADOOP-13786-041.patch, HADOOP-13786-042.patch, 
> HADOOP-13786-043.patch, HADOOP-13786-044.patch, HADOOP-13786-045.patch
>
>
> This is a Yetus only JIRA created to have Yetus review the 
> HADOOP-13786/HADOOP-14971 patch as a .patch file, as the review PR 
> [https://github.com/apache/hadoop/pull/282] is stopping this happening in 
> HADOOP-14971.
> Reviews should go into the PR/other task



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to