[
https://issues.apache.org/jira/browse/HADOOP-15003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16242825#comment-16242825
]
Aaron Fabbri commented on HADOOP-15003:
---------------------------------------
Latest changes look OK.
javac warnings are deprecation (unavoidable AFAICT). It looks like a couple of
the checkstyle warnings can be fixed still. Many are unavoidable (parameter
counts, javadoc link line lengths).
Whitespace needs to be fixed when applying patch, of course.
I still reproduce a failure with parallel tests here:
{noformat}
Tests run: 7, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 31.163 sec <<<
FAILURE! - in org.apache.hadoop.fs.s3a.commit.magic.ITestHugeMagicCommits
test_030_postCreationAssertions(org.apache.hadoop.fs.s3a.commit.magic.ITestHugeMagicCommits)
Time elapsed: 1.551 sec <<< ERROR!
java.io.FileNotFoundException: No pending file: not found
s3a://fabbri-new/tests3ascale/ITestHugeMagicCommits/commit/__magic/job_001/commit.bin.pending
in s3a://fabbri-new/tests3ascale/ITestHugeMagicCommits/commit/__magic/job_001
at
org.apache.hadoop.fs.s3a.S3AFileSystem.s3GetFileStatus(S3AFileSystem.java:2205)
at
org.apache.hadoop.fs.s3a.S3AFileSystem.innerGetFileStatus(S3AFileSystem.java:2099)
at
org.apache.hadoop.fs.s3a.S3AFileSystem.getFileStatus(S3AFileSystem.java:2038)
at
org.apache.hadoop.fs.contract.ContractTestUtils.verifyPathExists(ContractTestUtils.java:900)
at
org.apache.hadoop.fs.contract.ContractTestUtils.assertPathExists(ContractTestUtils.java:884)
at
org.apache.hadoop.fs.contract.AbstractFSContractTestBase.assertPathExists(AbstractFSContractTestBase.java:294)
at
org.apache.hadoop.fs.s3a.commit.magic.ITestHugeMagicCommits.test_030_postCreationAssertions(ITestHugeMagicCommits.java:125)
{noformat}
Which went away when I ran the test in isolation. Again don't consider this a
blocker as (1) only affects parallel (2) magic not staging, (3) we need to get
this stuff committed to a branch so others can collaborate on polish like
parallel test flakiness etc.
I'll let you fix the checkstyle since you asked me not to help with committing
it.
> Merge S3A committers into trunk: Yetus patch checker
> ----------------------------------------------------
>
> Key: HADOOP-15003
> URL: https://issues.apache.org/jira/browse/HADOOP-15003
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Affects Versions: 3.0.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Attachments: HADOOP-13786-041.patch, HADOOP-13786-042.patch,
> HADOOP-13786-043.patch, HADOOP-13786-044.patch, HADOOP-13786-045.patch,
> HADOOP-13786-046.patch
>
>
> This is a Yetus only JIRA created to have Yetus review the
> HADOOP-13786/HADOOP-14971 patch as a .patch file, as the review PR
> [https://github.com/apache/hadoop/pull/282] is stopping this happening in
> HADOOP-14971.
> Reviews should go into the PR/other task
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
